3.5.0 #161
3.5.0 #161
Conversation
This reverts commit 946f562.
* added DkCoreDocumentReference * Update aliases.fsh * Alternative DocRef approach (#158) * Alternative DocRef approach * Further danish constraints * Removed unused alias * update scripts * Update DkCoreDocumentReference.fsh --------- Co-authored-by: Ole Vilstrup <[email protected]>
150 profiling of encounter
Added context.sourcePatientInfo only Reference(DkCorePatient)
outcommented context.sourcePatientInfo only Reference(DkCorePatient)
Created short intro page for DocumentReference
Explicit display values for IEEEx73 codes no longer needed
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 19 out of 19 changed files in this pull request and generated 8 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
input/pagecontent/StructureDefinition-dk-core-encounter-intro.md
Outdated
Show resolved
Hide resolved
input/pagecontent/StructureDefinition-dk-core-encounter-intro.md
Outdated
Show resolved
Hide resolved
| * ^contact.telecom[=].value = "[email protected]" | ||
| * ^experimental = false | ||
| * ^caseSensitive = false | ||
| * ^caseSensitive = true |
There was a problem hiding this comment.
The caseSensitive property for the NPU CodeSystem is being changed from false to true. This is a breaking change that could affect existing implementations. NPU codes should be validated to ensure they are consistently cased in all existing profiles, examples, and value sets. Please document this breaking change in the release notes.
input/pagecontent/StructureDefinition-dk-core-minimaldocumentreference-intro.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 19 out of 19 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
input/fsh/DkCorePractitioner.fsh
Outdated
| * ^slicing.discriminator.path = "identifier.system" | ||
| * ^slicing.rules = #open | ||
| * ^slicing.ordered = false | ||
| * ^slicing.description = "Slice based on the identifier.systemm value which allows for official qualifications to\nDeclaring the slices, and their cardinalities, to allow a KL-code and a SNOMED CT code" |
There was a problem hiding this comment.
@jkiddo Note that Copilot actually found and fixed a spelling mistake in the change suggestion above that you missed: systemm -> system
input/pagecontent/StructureDefinition-dk-core-encounter-intro.md
Outdated
Show resolved
Hide resolved
Clarify the role of the implementation guide in relation to the FHIR standard and the IPA specification.
…iblity and link to example of diagnosis and ranks.
[(181-review-encounter-example-missing)] More descriptions of respons…
input/pagecontent/StructureDefinition-dk-core-encounter-intro.md
Outdated
Show resolved
Hide resolved
input/pagecontent/StructureDefinition-dk-core-encounter-intro.md
Outdated
Show resolved
Hide resolved
| Extension: DkCoreDocumentReferenceVersionID | ||
| Id: dk-core-documentreference-version-id-extension | ||
| Title: "HL7 Denmark core DocumentReference Version ID extension" | ||
| Description: "Extension containing information about the version of the DocumentReference for a specific standard. The version is included in the R5 version of the resource." |
There was a problem hiding this comment.
The extension is missing context definition. Extensions should define where they can be used via ^context.type and ^context.expression. For a DocumentReference version extension, add:
* ^context.type = http://hl7.org/fhir/extension-context-type#element
* ^context.expression = "DocumentReference"
| Description: "Extension containing information about the version of the DocumentReference for a specific standard. The version is included in the R5 version of the resource." | |
| Description: "Extension containing information about the version of the DocumentReference for a specific standard. The version is included in the R5 version of the resource." | |
| * ^context.type = http://hl7.org/fhir/extension-context-type#element | |
| * ^context.expression = "DocumentReference" |
| * extension[0].url = "http://hl7.dk/fhir/core/StructureDefinition/dk-core-planned-start-date" | ||
| * extension[=].valueDateTime = "2025-11-14T09:00:00.0000+01:00" | ||
| * extension[+].url = "http://hl7.dk/fhir/core/StructureDefinition/dk-core-planned-end-date" | ||
| * extension[=].valueDateTime = "2025-11-15" |
There was a problem hiding this comment.
[nitpick] The planned end date uses a date-only value "2025-11-15" while the planned start date uses a full dateTime "2025-11-14T09:00:00.0000+01:00". For consistency and clarity, consider using the same precision (dateTime format) for both planned dates, especially since the extension is defined as valueDateTime.
| * extension[=].valueDateTime = "2025-11-15" | |
| * extension[=].valueDateTime = "2025-11-15T09:00:00.0000+01:00" |
input/pagecontent/StructureDefinition-dk-core-encounter-intro.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <[email protected]>
* Initial plan * Fix typo: reponsibilities -> responsibilities Co-authored-by: jkiddo <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: jkiddo <[email protected]>
No description provided.